Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding FUNDING.yml #271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adding FUNDING.yml #271

wants to merge 1 commit into from

Conversation

julien51
Copy link

Changes

As an Open Source project, we @unlock-protocol believe Ethlint should have a FUNDING.yml file which lets people make donations if they use the software, like we do ;)

This pull requests adds donation thru an Unlock lock. Locks are smart contract which let people become members by purchasing a key. The key itself is a non fungible token: 🗝 .

You can make a donation (and purchase a key!) on this page (linked inside of the FUNDING.yml file)

This specific lock is at 0x439feA1207F37557AEB85cFFaB1e28A29bbEB7FF. The curent key price is 1 DAI. I currently own the lock but I'll happily transfer its ownership to you if you can send me an address ;) After that, you will be able to update the price, the name and withdraw the funds from the Unlock dashboard.

Keys are valid for 1 month and there can be an infinite number of keys.

PS: if you want to create your own FUNDING.yml link you can easily with this application.

Declaration

  • I have followed the Contribution Guidelines.
  • All tests are passing.
  • ESLint doesn't produce any warnings.
  • ESLint doesn't produce any errors.
  • I'm awesome.

NOTE: It is fine if ESLint does produce warnings for your PR if there is a good reason for it.

@julien51
Copy link
Author

PS: we're using EthLint (cc @NickCuso) and we're quite happy with it which is why we thought it would be good to show some support!

@julien51
Copy link
Author

One quick addition, when/if you merge this you also need to enable donations in the settings (see https://github.com/duaraghav8/Ethlint/settings) :

image

@julien51
Copy link
Author

julien51 commented Sep 3, 2019

Hello @duaraghav8 ! I'd love to get your feedback on that one. We blogged about the motivations behind that PR.

One of the next steps that we're thinking of is to create some kind of "shared" lock between many Ethereum OSS projects. The idea is that people can then chose to support a single project, like Ethlint, or the whole ethereum OSS ecosystem. This shared lock would belong to some kind of shared address (or even a DAO) to organize the funds and maybe distribute them to specific projects.

Anyway, my point is that I'd love to kick off a discussion here :)

@duaraghav8
Copy link
Owner

Hey @julien51 sorry for reverting back so late.
I see that this PR introduces a change that is tied to a particular tool/organisation. I've refrained from from letting such changes make it to master, because this has caused unwanted coupling/vendor lock-in in the past.
Since @unlock-protocol seems beneficial, I'll keep this PR open until I read up & gain more context on it.
But hopefully you won't be discouraged from making future contributions if I decide to turn this PR down :) Thanks

@julien51
Copy link
Author

julien51 commented Sep 9, 2019 •
edited
Loading

@duaraghav8 Thanks for the follow up!
I agree about the challenges to add "dependencies". I would argue that here this is does not "tie" Ethlint's code or execution but just adds an easy way for people to contribute to your work :)

I am of course happy to answer any question you may have and would love to help you further!

In the meantime, I wrote more about that DAO idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien51 @duaraghav8